Design comparison
Solution retrospective
HHey there!
I've achieved another challenge. Feel free to give me tips and tricks about JavaScript code, or on HTML and CSS if you notice anything that can be improved.
Community feedback
- @MelvinAguilarPosted about 1 year ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
-
If an element performs an action and has a hover event, it's a clear indicator that it's an interactive element like a button or a link. In this case, adding an event listener to a
<div>
might not be the most semantically appropriate choice, as<div>
elements are typically used for grouping and styling purposes.To improve the accessibility and interaction, you could consider changing that <div> to a
<button>
, which is a more suitable element for interactive actions. You can then apply any necessary styles to the<button>
using CSS.
- Similarly, for the social media icons in the toggle, enclosing them in
<a>
(anchor) tags would be a good practice. It's a common practice to wrap social media icons in links to simulate the action of visiting a social media profile when clicked. This would enhance the user experience.
I hope you find it useful! ๐
Happy coding!
Marked as helpful1@KevallionPosted about 1 year ago@MelvinAguilar
Hi, thanks for your feedback, that definitely helps me a lot. I will immediately fix that!
Happy coding too! :D
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord