@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
-
If an element performs an action and has a hover event, it's a clear indicator that it's an interactive element like a button or a link. In this case, adding an event listener to a
<div>
might not be the most semantically appropriate choice, as<div>
elements are typically used for grouping and styling purposes.To improve the accessibility and interaction, you could consider changing that <div> to a
<button>
, which is a more suitable element for interactive actions. You can then apply any necessary styles to the<button>
using CSS.
- Similarly, for the social media icons in the toggle, enclosing them in
<a>
(anchor) tags would be a good practice. It's a common practice to wrap social media icons in links to simulate the action of visiting a social media profile when clicked. This would enhance the user experience.
I hope you find it useful! ๐
Happy coding!
Marked as helpful
@Kevallion
Posted
@MelvinAguilar
Hi, thanks for your feedback, that definitely helps me a lot. I will immediately fix that!
Happy coding too! :D