Article Preview Component with SASS

Community feedback

• 

  Agustin•340

  @agusc01Posted over 2 years ago

  Hi Asha.

  All images have empty alt="", iIt is important for search engines to understand what is in the photo and also for blind people

  Wrap each image icon into a anchor like <a href="#"> <img src="images/icon-facebook.svg" alt="icon facebook"></a>

  This will look better .share:hover { cursor: pointer; }

  And look what happens (on mobile version) writting this @media (max-width: 850px) { //... .info-and-share:not(.active) { margin-bottom: -0.8rem; } }

  You can add this

  @media (max-width: 850px) { img { //... border-radius: 10px 10px 0 0; } }

  In my opinion you should use relative units instead absolutes units

  Keep coding ! Great job !

  Marked as helpful

  1

  ---

  

  Asha•1,210

  @livinglifemeaningPosted over 2 years ago

  @agusc01 Thank you so much for your comments! I like to use relative units, but am not sure quite how when there's a photo that is going to stretch with the container or when there is absolutely positioned elements like in this project.

  0