Article preview component with Sass and Flexbox

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  _ <img src="images/drawers.jpg" class="image" alt="Loooool"> , alt values are not just any words . Assistive technology users rely heavily on such information to visualize the message that is being put across. If it is a decorative image , use an alt=""

  • your first heading should be an h1 and headings should ascend in order. Do not skip headings.

  Marked as helpful

  0

  ---

  

  Safi Nafi•415

  @Safi100Posted over 3 years ago

  @ChamuMutezva thanks for your help ,I appreciate it <3

  0
• 

  Hafizan Adli•1,190

  @hafizanadliPosted over 3 years ago

  You did great, it looks good and responsive.

  Here my suggestion:

  • trying to use semantic html such as section,main,footer,etc. instead of using only div
  • Do not over qualifying selectors, if class name already unique, you can select that element with that class name, for example if you want to select name-date element you can simply use .name-date selector instead of (.container .information .person .name-date)
  • For name date section I would rather use p tag instead of span, since p is block element

     <div class="name-date">
            <p>Michelle Appleton</p>
            <p>28 Jun 2020</p>
          </div>
  

  Marked as helpful

  0

  ---

  

  Safi Nafi•415

  @Safi100Posted over 3 years ago

  @hafizanadli I used Sass and type .person { .name-date{ ... } }

  if you look in main.css it will automatically write (.container .information .person .name-date)

  thanks for your help, I appreciate it <3

  0