Design comparison
Solution retrospective
HTML & CSS, Responsive Layout, BEM CSS class naming convention
What specific areas of your project would you like help with?Feedbacks and advices are always welcomed 😊
Community feedback
- @BunchydoPosted 12 days ago
Hi Ali Reza,
I really like how the design turned out!!
Semantic HTML: Rocking the semantics! Try using <article> for .card since it's a standalone piece, and replace <div class="card__title"> with <header> to better frame the content.
Accessibility: Enhance accessibility by adding specific alt text to images, so users know exactly what’s displayed. Ensure focus outlines are clear on the share button and icons, and add aria-labels (e.g., "Share on Facebook") for smoother screen reader navigation.
Responsive Design: Layouts look great on most screens—just test on narrower ones to make sure text stays readable!
Code Structure: Love the clean CSS and variable use! Adding a few comments in the JavaScript can make it even easier to follow as the codebase grows.
Consistency & Reusability: Check padding/margins on .card__body and font sizes to fully match the design. Plus, you could generalize some hover effects to make styles even more reusable.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord