Article Preview Component - Vanilla Mobile First

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted about 3 years ago

  Hi

  This doesn't work for me. Events should never fire off elements like image or anything non-interactive. If you use a button it might work

  Marked as helpful

  1

  ---

  

  T

  Grace•31,270

  @grace-snowPosted about 3 years ago

  In fact, if I click with a mouse not keyboard it is catching the event (still must be changed to a button) but the javascript isn't working. Social stays hidden and visible gets logged to console.

  Once this is a button, it needs to have an aria-expanded attribute on it. You only need one event listener, eg. toggleShare

  That function needs to:

  • toggle the hidden class
  • toggle the aria-expanded value

  There is no reason for there to be two functions, or for it to add/remove other classes like flex. You can handle that already in css

  Good luck

  Marked as helpful

  0
• 

  Phil•185

  @PhilJGPosted about 3 years ago

  @grace-snow Yes Im not sure why the script doesnt work on my live site. Something must have happened when I uploaded onto github. Im still new to github and markdown and I cant figure out how to push my updates to it.

  But I have taken your suggestions into account and now I have the toggle working :) I was not familiar with '.toggle' until now!

  0