Article preview component Vanilla JavaScript, and Flexbox

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  Hey, Eileen dangelo! 👋

  Great work on this challenge! 👍

  Here are a few things I'd like to suggest,

  • Setting the width of the card component in this challenge to 100% and then adding a max-width to it to prevent it from becoming too wide when there's plenty of space around it. This is often better than setting the width of the element to a fixed value or percentage because it'll ensure that the element takes up as much space as it should be allowed but also shrinks accordingly when its parent element shrinks.
  • You'll want to add some padding to the inside of the body to make sure there's space between the edges of the screen and the card component after making those changes to its width.
  • Adding some more descriptive text for the alt attribute of the profile image. This text will be read by screen readers, so it's important to make sure that it makes sense to users who use screen readers.
  • Turning the social media links in the social media popup of the component into actual links by wrapping each of them in a link tag. You may also want to add some screen reader-only text inside those links or add an aria-label attribute to them instead to make sure they can be identified by screen readers.

  Hope this helps. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  1