Article preview component using HTML + CSS + Vanilla Javascript

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello there, Jose Angel Rey! 👋

  Nice work on this challenge! 🙌 The card component is looking pretty nice and the smooth transition of the popup is a nice touch! 👍

  I'd like to suggest labeling the button elements on the page in some way (to clear up those errors on your solution report and improve the accessibility of your solution) and wrapping the social media icons in anchor tags since they seem to be links. 😉

  Keep coding (and happy coding, too)! 😁

  0
• 

  Agata Liberska•3,995

  @AgataLiberskaPosted over 3 years ago

  Hi @Jose-Angel-Rey, your solution looks great! I love the modal transition, but I think it could be sped up a bit, to 500ms maybe? Also on very small mobiles (under 300px, I know it's an edge case but still), one of the social media icons disappears under the toggle.

  Hope this helps :)

  0