Article Preview Component using flexbox (and a small amount of grid)
Design comparison
Solution retrospective
Any feedback on how to improve my code is welcome!
Community feedback
- @mubaraqwahabPosted over 4 years ago
Hey this is good, well done!
I have two comments:
-
The avatar seems stretched on desktop. I think giving the
.user-avatar__container
a width equal to its height should fix it (width: 4rem;
perhaps). -
Second thing, I think it would be good to have the share button as a
<button>
not a link. As a link, clicking it scrolls the page back to the top.
1@AFLazaroPosted over 4 years ago@mubaraqwahab
-
That's interesting, it looked fine on Firefox but I checked in Chrome and it was stretched out as you said. This has been fixed.
-
Excellent suggestion, I've changed the anchor element to a button.
Thanks for the feedback!
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord