Design comparison
Solution retrospective
Hello everyone! This is my first challange and I'd like to know if I'm using BEM and SCSS in good way. Thanks for all responses.
Community feedback
- @luisdevworksPosted about 4 years ago
Hello Sebastian,
You're using BEM and SASS in a good way, in my opinion.
Besides that, I have some observations.
The color of the share button should be different when it's clicked as you see in the design, you can change the svg code with css and apply using JS when clicks.
The bottom of the card should have also a border radius.
And finally, what about the desktop design?
For everything else, works great, and it's very good for your first challenge!
Keep going, good work!
1@surbaniecPosted about 4 years ago@luisdevworks thanks for answer. I fixed all the bugs
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord