Submitted about 3 years ago
Article preview component using BEM, Sass and JS
@LudovicLefieux
Design comparison
SolutionDesign
Solution retrospective
Hello everyone ! I'm new to Javascript so my solution isn't the best. I noticed a few bugs when I spam the share button. If you have any solution, please feel free to let me know in the comments.
Community feedback
- @guztrilloPosted about 3 years ago
Hey LefieuxL, great solution. Looks good. The only advice I can give you is that instead of name every single tag to set
margin: 0
andpadding: 0
you could just use the universal selector*
, just like this:* { margin: 0; padding: 0; }
This will select every single element on the page.
0@LudovicLefieuxPosted about 3 years ago@guztrillo Hey Carlos ! Thanks for the advice. I will do this for my next challenge 😁
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord