Design comparison
SolutionDesign
Solution retrospective
Hey,
Kindly if you have time review my code and tell me if there any comments to improve the CSS or how could i make it more effective.
All comments are welcome and thank you in advance
Community feedback
- @Mostafa-TPosted about 4 years ago
First of all thank you for reviewing my code 😁. I really appreciate your improvement suggestions and will update my projects with your suggestion.
1@justAdevTVPosted about 4 years agoNo problem! I'm just happy to help. Let me know if you update it :)
0 - @justAdevTVPosted about 4 years ago
@Mustafa, it looks pretty good on my desktop. Nice touch with the share button animations!
Suggestions for improvement:
- Use rem or em instead of px for fonts.
- At 772 width, the padding and fonts look a bit off. I don't think it would hurt to add another breakpoint here.
- Add a box-shadow to the card. If you're trying to get closer to the mockup it's some easy points :)
Hope this helps, Justin P.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord