Article preview component | Sass, BEM naming, and smooth animations

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hi, spymon! 👋

  Great job on this challenge! 🙌 The card component looks good and is responsive and I really like the animation that you added to the social media popup! 👏

  I only suggest taking a look at your solution report and trying to clear up some of the errors that are there. You should probably label the button in some way (to identify it) and add a <title> tag to the inline SVGs to improve the accessibility of your solution. 😉

  Hope that helps. 🙂

  Keep coding (and happy coding, too)! 😁

  2

  ---

  

  spymon•90

  @spymonPosted over 3 years ago

  @ApplePieGiraffe

  Wow, thank you ApplePieGiraffe! 😍 Did I just received a comment from the number one person from the wall of fame of all time? What an honor and a motivation boost at the same time! 🤩

  I researched how to use the <title> tag and aria attributes. I failed few times to clear solution reports, but in the end, I did it. 🙌

  I learned a lot about attributes:

  • aria-expanded,
  • aria-controls,
  • aria-labelledby,
  • role,
  • title

  and how to implement them correctly, I guess. Correct me if I am wrong 😅

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @spymon

  Haha—wow, thank YOU, spymon! 😊 It's great that you learned a little bit more about all of those attributes and accessibility in general! It's a valuable part of web development that people sometimes forget to pay attention to, but it's very important and shows you care about all users of your site! 😀

  Good work on clearing up your solution report! Keep it up! 👍

  1