Article Preview component responsive design

Community feedback

• 

  David•8,000

  @DavidMorgadePosted about 2 years ago

  Hello Ritesh!, nice job with the solution of the challenge, your layout is great and the responsiveness works perfect!

  If you don't mind I would like to give you a few suggestions:

  • Regarding you Javascript file, I think it would be better and more clear if you write it on a different file and link it to the html instead of just wrting it on the html file, you can use your tag, setting the src to the path of your Javascript file to make it work!

  • For the CSS I have nothing to say, great job and keep it like this!! the result was very good.

  • And for the html part, you should try using some semantic tags to divide your project, like main, section also remember that all documents should have one h1 tag, this will improve the accesibility and it will help topup your page on search engines! Also would add your img inside of a tags because they are going to take you to other page (facebook, twitter, pinterest) so since they are used for navigation, anchor tags are perfect!

  Hope my feedback helps you, I encourage you to try harder challenges and keep going! good job!

  Marked as helpful

  1

  ---

  

  Ritesh_Gupta•520

  @b4n1y4Posted about 2 years ago

  @DavidMorgade Thank you so much. This was really helpful. 🙏

  1