Design comparison
Solution retrospective
This project was fun and challenging.
What I found most difficult about building this project is knowing the best approach in knowing when and how to set aria attributes like aria-expanded on click in React.
Here are areas I am still unsure of: (I am guessing these questions could fall under best practice questions too)
- If I successfully implemented the aria-expanded attribute to the button element onClick with React.js
- For adding modals, does it matter where you add them in your layout. I was given advice to move the shared content modal to inside the card footer div in lieu of having it within my main tag. I followed the advice but I didn't understand exactly why I moved it because it didn't seem to change anything
- I added
aria-hidden= "true"
on all inline SVG's as instructed too but again I didn't know why I did it. What is the reason? Also does this apply to images too? If not, then why? - Also for the modal, was it the right decision to use position absolute on it? I thought about using
transform: transformY(px)
on it but thought positioning was better - Were there any areas of my code, that aren't very readable to the next developer? Ex) using styled components allows you to create your own named components. Do my names make sense or can I simplify it?
This is all I could think up for now. Thank you for your time
Community feedback
- @fazzaamiarsoPosted over 2 years ago
Hello Brian! Nice try on implementing those accessibility improvements!
I can answer some of your questions.
- The first thing you want to make sure accessible is the keyboard access. When I go through your page with keyboard, I was lost. You MUST have either focus or focus-visible style to focusable elements. https://www.w3.org/WAI/GL/UNDERSTANDING-WCAG20/navigation-mechanisms-focus-visible.html
aria-hidden="true"
is to prevent screen readers from reading or detecting the SVGs.
I know it's tough to learn accessibility as there are not many resources out there. But, I can give you a useful tips to learn accessibility that I discovered along the way. Please try to go read and understand the source code of libraries such as Reach UI and Headless UI. They are amazing libraries on making accessible components that you can learn from.
I hope it helps! Cheers!😁
Marked as helpful1@BrianJ-27Posted over 2 years ago@fazzaamiarso
Thanks for such detailed feedback. So just so I am clear, regarding keyboard accessibility, I need to add the pseudo
:focus
styles on my button elements and that will correct the issue?Thanks Brian
0@fazzaamiarsoPosted over 2 years ago@BrianJ-27 yes, you are right. However, If you just want it visible on keyboard interactions, you can do
focus-visible
.1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord