Article preview component – plain HTML/JS/CSS using BEM

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted almost 4 years ago

  Hi This is really good and your BEM looks great to me. We'll done, it's not easy to grasp at the start!

  If you want to improve the accessibility, I'd recommend

  • adding an Id to the share-box
  • adding aria-controls to the share button, with a value of that ID
  • Adding aria-expanded to the share button with an initial value of false

  In js, on click you would then

  • toggle aria-expanded to true
  • toggle the text of the share buttons aria label value between "share" and "close share options" (or something like that)

  I hope that all makes sense and is helpful to you. And again, well done on this 👍

  3

  ---

  

  Maria•290

  @itsfedorukPosted almost 4 years ago

  thanks Grace, appreciate your review and tips – always so valuable! I updated my solution and will keep it in mind 🙌

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey there, Maria! 👋

  Nice to see you complete another challenge! 😀 Well done on this one! 👍 I think your solution looks great and responds well (the social media popup works nicely, too)!

  A super minor suggestion I might make may be to add a hover state to the social media links in the popup. 😉

  Otherwise, keep coding (and happy coding, too)! 😁

  1

  ---

  

  Maria•290

  @itsfedorukPosted almost 4 years ago

  thank you so much, appreciate your review! that's a good add-on – I included it now in my updated solution :)

  1