Design comparison
SolutionDesign
Solution retrospective
Hello! I just learned JavaScript and I want to learn more about it through this challenge. This one was fun for me! I'm sure there are still many things that I can improve on, so please take a look at my solution and leave a comment to help me improve! Thank you so much!
Community feedback
- @SatheesAPosted almost 2 years ago
Looks good, you got it to look relative close to the original. Some issues I´ve noticed on the solution:
- when you toggle social on off in mobile view there is a flicker and shift of the layout.. If you can avoid the flicker it will look better...
- you have a media breakpoint at 705px and the main grows in width until the breakpoint. You should have a max-width at some point so it doesn´t keep growing. The card at some point doesn´t look good anymore.
share-iconis a ´div´ instead of a ´button´.. If not using a button you should read more about it here: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/button_role
Marked as helpful1@charmonderPosted almost 2 years ago@SatheesA Thank you so much! I'll take a look at your suggestions :)
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord