Skip to content
Submitted over 1 year ago

Article preview component master project

cmb347827•750
@cmb347827
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Article preview component
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • This solution generates accessibility error reports due to lack of lang attribute of html element
    • <html> element must have a lang attribute with valid value, so fix it by <html lang="en">
    • And for Buttons, The <button> must have discernible text that clearly describes the destination, purpose, function, or action for screen reader users.
    • So fix it by,
    <button class="some-classes" aria-label="Share"></button>

    I hope you find it helpful ! 😄 Above all, the solution you submitted is great

    Happy coding!

    Marked as helpful
    0
  • cmb347827•750
    @cmb347827Posted over 1 year ago

    Thanks, I usually validate my code at https://validator.nu/#textarea , which picks up small oversights like this. And the accesibility aria-label, yes I need to remember accesibility as well.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord