Design comparison
Solution retrospective
First time creating a project with some JavaScript in it, albeit a very small amount.
Appreciate any feedback on the structure of my code. If there's an easier way to do anything I've done, please let me know!
Thanks :)
Community feedback
- @AuddityPosted almost 3 years ago
The JS is good.
A couple syling suggestions:
Put your share element (.share) inside your .wrapper element. The positioning of the .share element will be easier for placing it at the very bottom of the card.
For mobile view you can use both arrow images positioned in the same place. Then toggle visibility for them in the JS as well. Making it appear like it's the same button that's just changing color.
Lastly you can fix your error in the report by replacing the <button> with an anchor tag.
Cheers, keep it up, it's looking good.
Marked as helpful0 - Account deleted
Hi there 👋
Congratulate on finishing your project 🎉. You did a great job 🔨. Your javascript is looks clean and dry
Happy coding ☕
Maqsud
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord