Article preview component

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Awesome work with this one. Viewing at your solution, I would recommend the following for you...

  • Add padding: 1rem; in the main rule set
  • Adjust the properties in h1 rule set into font-size: 1.2rem; and line-height: 1.5rem;
  • Adjust the font size of p into font-size: 0.8rem;
  • Include alt with description in the img tag
  • Refactor this part of the code:

   <button>
              <a href="https://facebook.com" target="_blank"
                ><img src="images\icon-facebook.svg"
              /></a>
  </button>
  

   - Remove the `button` tag, it's improper to wrap the `a` with a `button`, it's good to use it as an alternative.
   - Be careful with the use of slashes, use the correct way which is `/`
  

  • Wrap the card-lower with div instead of section which need at least one heading hierarchy
  • Include transition: all 200ms ease in the button

  Overall you did well, your CSS is fine. Keep practicing and Hope this helps! Cheers!

  0