Article preview component, HTML/SCSS/JS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Kevin Canlas! 👋

  Nice job on this challenge! Everything looks pretty great and the social media popup works nicely! 👏

  I suggest,

  • Adding a max-width to the card component so that it isn't too wide when the layout first changes from desktop to mobile.
  • Using the <button> element for the social media popup button so that keyboard users can access and use that button.
  • The top-left and top-right corners of the card component aren't rounded in the mobile layout of the site. Don't forget to add those!

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Kevin Canlas•225

  @kvncnlsPosted almost 4 years ago

  @ApplePieGiraffe Ah! I forgot about the borders! I added it to the 768px media query, but not the mobile haha. I'll add the max-width and use button now too! Thanks APG!!

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @kvncnls

  NP! Keep it up! 👍

  1