Article preview component | HTML CSS & JS | Flexbox & Grid
Design comparison
Solution retrospective
I am just a beginner and would appreciate any feedback.
Do I have good practices? What errors do I have? How could I improve my code?
Thanks <3
Community feedback
- @SzymonRojekPosted almost 4 years ago
MasterKrab
Your solution looks nice.
@alnahian2003 has got right - the box-shadow is too strong.
You have used the tag main. Ok, but maybe it will be better to change the name of the selector to “card”, what do you think? Also, the main selector has got border-radius 1em, then profile social—active is set to 0.5em. I would do it equally. Check it out.
Also, I am just thinking 🤔 maybe I would use the tag section here and inside the article tag but I don’t want to make it more complicated.
You have got two index.html in your repository and also unnecessary files can go to .gitignore.
Ps. don't forget to upvote any comments on here that you find helpful.
Many greetings :D
3 - @alnahian2003Posted almost 4 years ago
Hey, Looks good & nice. But would you mind to decrease the opacity of the box-shadow? It looks a little bit heavy.
Keep going <3
Happy Coding :)
2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord