Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Article preview component - Flexbox / DOM

@aazs-edu

Desktop design screenshot for the Article preview component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  • Initiating the share options was a bit challenging, especially because it varies depending on the screen. But I got it in the end 💪.
  • Feedback would be appreciated, and I will mark it as helpful. 🙏

Community feedback

@AGutierrezR

Posted

Hello there 👋. Good job on completing the challenge!

I have some suggestions about your code that might interest you.

CSS and Styling:

  • Avoid using px for font-size, you could read this article to learn why. Letter spacing and line height must not be in px, use rem for all the font-related properties.
  • Instead of fixed widths, employ max-width and min-width for flexible and responsive design.

Accessibility and Semantic HTML:

  • The icons/illustration images are decorative, so their alt text must be emptyalt="".
  • Profile image could benefit from a more descriptive alt text, like alt="Headshot of Michelle Appleton" or you could leave it empty alt="".
  • Buttons with only icon as content can benefit from aria-label or sr-only element. Like the share button.

I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!

Happy coding!

Marked as helpful

2

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord