Design comparison
SolutionDesign
Solution retrospective
feedback welcome
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The profile images
alt tag
need to be improved. It should state the following; “Headshot of -person’s full name-“
- Your "share button" needs to be created using the
button
element to make it accessible by keyboard.
- Currently, when you click on the "share button" you can open the modal but not close it. That is because you JS is only "adding" classes. It should be doing both add and remove. Change the
add
totoggle
and this will do both.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful0 - The profile images
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord