Design comparison
Solution retrospective
Hello!
Here I am with another project. This one is much more "streamlined" and "clean" in terms of HTML and CSS semantics.
I wanted to work as much as possible on this part because I was using WAY too many <div>
and ```<class="">```` in my opinion. It made everything really suffocating.
Although I still have a long way to go, and I haven't been able to finish it properly.
Yet, I am still satisfied with the result.
Once again, I will browse through the "solution" section to see what I could have done better and should have done to achieve it at 100%.
Good luck to everyone and have a nice day!
P.S.: The easter egg is poorly coded but still interesting.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS 📐:
- Use
min-height: 100svh
forbody
instead ofheight: 100svh
. Setting theheight: 100svh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100svh
then thebody
will have100svh
height no matter what. Even if the content spans more than100svh
of viewport.
- But if we set
min-height: 100svh
then thebody
will start at100svh
, if the content pushes thebody
beyond100svh
it will continue growing. However if you have content that takes less than100svh
it will still take100svh
in space.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord