Article Preview Component built with BEM, SASS/SCSS and JavaScript.
Design comparison
Solution retrospective
Got to finish another, really happy about that.
- what do you guys think of my Markup? how do you think i could have done it better?
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @johnnysedh3lllo!
Your solution looks excelent!
I have just one suggestion:
š In order to make your HTML code more semantic, use
<h1>
for the main title instead of<h4>
.Unlike what most people think, it's not just about the size and weight of the text.
-
The
<h1>
to<h6>
tags are used to define HTML headings. -
<h1>
defines the most important heading. -
<h6>
defines the least important heading. -
Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.
All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful1@johnnysedh3llloPosted 10 months agothanks for the feedback @danielmrz-dev , i appreciate.
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord