article preview component

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hey there, Luis Colina! 👋

  Nice effort on this challenge! 👏

  I suggest,

  • Adding a fixed width and height to the card component in the desktop layout and simply changing those properties with a media query when the screen size decreases in order to make sure the width and height of the card don't become too large or too small when the size of the screen changes.
  • Adding object-fit: cover to the image of the card component to make sure that it is clipped (rather than stretched or squeezed) when the size of the card changes.
  • Turning the social media icons in the social media popup into links using the anchor tag.

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Luis Colina•1,043

  @Comet466Posted over 3 years ago

  @ApplePieGiraffe thank you applePie, i already added the anchor tags to the code, about the fixed width i agree that it looks ugly when every component start to shrink due the use of relatives units, i will keep it in mind for my next challenge, also didn't know about the property "object-fit" this will help me for now on, thank you for taking the time of reading my code it means a lot

  1
• 

  Marko•75

  @robot200Posted over 3 years ago

  This looks great

  1

  ---

  

  Luis Colina•1,043

  @Comet466Posted over 3 years ago

  @robot200 thank you Marko, appreciate it

  0