Design comparison
Solution retrospective
Finally, another project is done within two days. Next time am planning to add js on every part of the project I do.
What challenges did you encounter, and how did you overcome them?I encountered the challenge of aligning displaying the image on top of the parent so that the rest of the children are below it but I finally got by looking into the code to see where the problem was.
What specific areas of your project would you like help with?I am currently learning js and it would be the great part of the area I would like help with.
Community feedback
- P@schindlerdumagatPosted 17 days ago
Upon checking the live site, it seems that this project is not yet finished. I can still see some inconsistencies like the colors, spacings, responsiveness, etc. But I would like to give some feedback on some of the things that I can see right now as incorrect and provide some recommendations.
Here are my recommendations:
- It is better for performance to link fonts in HTML head tag instead of link it in the CSS file because it is the HTML file that the browser receives first before anything else.
- You should put all the contents of your HTML body tag in a landmark role for accessibility reasons. In this particular, you should enclose the contents of the body element in a main tag. You can read more about landmark roles on the internet and see why it is necessary.
- You should use heading tags in order (from h1 to h6). Don't use heading tags just to make the font size of a text smaller or bigger. You can do that in the CSS instead.
- Even if you are already learning JavaScript, you should still revisit your HTML and CSS because it seems like you have missed some of the most important concepts and knowledge when working with HTML and CSS.
Marked as helpful0@MatthewNgabiranoPosted 17 days ago@schindlerdumagat Thanks very much for the feedback Mr. schindlerdumagat I Am working on fixing those small errors.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord