Article preview component

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Congrats on completing the challenge successfully! Everything looks great and it is responsive as well.

  "Is it alright to toggle visibility of the share section using the way I did (creating class hidden and giving it a display:none, and then in js file creating function that toggles the class)"

  Yes, the way you did with class toggle is perfectly fine and valid. In fact thats also how i did it for this challenge. Only thing is, when you want to add an animation, it becomes tricky as it cannot be animated from display:block to none. But there are other workarounds like changing opacity etc.

  On a small note, you could also change cursor:pointer; for the button in addition to background change, as it indicates user that it is a clickable button.

  Hope you find this feedback helpful!

  Marked as helpful

  1

  ---

  

  Michal Bednář•140

  @MichalBednarPosted over 1 year ago

  @visualdenniss Thank you, I always try to apply the pointer for clickable elements, but it looks like I forgot this time, so I'm, glad you noticed!

  1