Article Preview Component

Community feedback

• 

  Ken•935

  @kenreibmanPosted about 3 years ago

  Great job! Your styling looks great. Just a few suggestions:

  Make sure you wrap your content with the correct HTML Semantic Elements In your case, I would wrap all the contents inside including article in a main tag.

  I would also do that for your attribution section as well. However, this time I would wrap all the contents inside including the div class="attribution in a footer tag.

  Instead of using article for your card, I would recommend just using a div.

  If you are using section tags, your heading tags should always start in chronological order. You are missing an h1 in a lot of places which create HTML issues.

  I hope this helps. There is nothing wrong when it comes to visual aspects of your project. I'm just giving you tips on better practice. Your JavaScript is also A LOT cleaner than my attempt!

  Marked as helpful

  0