Design comparison
Solution retrospective
I was most proud of creating a page that is responsive and looks good!
I also learnt how to hide elements in HTML and css. We can do two things basically:
- Moving the element past the container and setting the container overflow to be hidden. This way, when we need the element, we can "drag" it from the hidden part
- Set opacity and visibility to zero.
Eh, creating the event was challenging but doable. The hardest part is changing the shape for the popup (the desktop and mobile overlay are different from each other).
Community feedback
- @mike15395Posted 4 months ago
@juliusalberto congratulations on completing the challenge!
You are very close to the design, i have noticed few bugs and mistakes which i would like to highlight to further improve your solution.
1. Image border radius
In your style.css file line no 26
.card .header-img { border-radius: 10px 10px 0 0; }
should be like this
border-radius:10px 0px 0px 10px
border radius is always in clockwise direction starting from left-top right-top right-bottom left-bottom.
2.Bug in mobile view When moving from desktop to mobile view at 768px breakpoint, the footer share icons appear for fraction of second then dissappear(without clicking share icon). May be this is happening because of transition css property, I am not sure but can figure it out.
Rest everything is good and well written! Good Efforts:) Keep Growing:) Happy Coding:)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord