git-Indrajit• 300
@git-Indrajit
Posted
Thank you for the suggestion
0
Design comparison
Solution retrospective
What are you most proud of, and what would you do differently next time?
JS
What challenges did you encounter, and how did you overcome them?
CSS
What specific areas of your project would you like help with?
JS,CSS
Community feedback
Daniel 🛸• 44,230
@danielmrz-dev
Posted
Hello there!
Congrats on completing the challenge! ✅
Your solution looks great!
I have a suggestion:
- Since you set grid to the body, but you didn't set the size of the rows, your footer is pushing your card up a little bit. You can prevent that from happening adding this to the body:
grid-template-rows: 90% 1fr;
Then your card will always occupy 90% of the space and the footer will adapt in the remaining space.
I hope it helps!
Other than that, you did an excellent job!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord