Article preview challenge with a lil bit of JS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hi there, Vjekoslav! 👋

  Good work on this challenge! 👍 The card component looks great and I like the smooth transition of the social media popup in the mobile navigation! 🙌

  I think this StackOverflow question might help you get rid of those errors in your solution report and make your solution more accessible. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Vjekoslav•485

  @Vj3koPosted almost 4 years ago

  @ApplePieGiraffe oh thanks for that, fixed it. i read the error and said to myself i will fix it later, and then forgot about it : /

  1
• 

  JK•345

  @JakubKepakPosted almost 4 years ago

  Man, that is one awesome solution! One thing I would maybe do differently is to set outline to none when .person_article-share is focused and I would add .person_article-share:focus same as you have .person_article-share:hover.

  But that's maybe just my view on outlines.

  Really nice job!

  1

  ---

  

  Vjekoslav•485

  @Vj3koPosted almost 4 years ago

  @JakubKepak thanks man, for your time reviewing my code and giving feedback, i really do appreciate it, and u are right about outline, thanks for that insight

  0

  

  Vjekoslav•485

  @Vj3koPosted almost 4 years ago

  @JakubKepak also, i added focus state, it really does make a visible change, thanks again, forgot about that outline stuff :D

  0