Article preview

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="main-container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Caleb Bankole•230

  @BankoleCalebPosted over 1 year ago

  Well done, you have done good job but I believe it can be only be better. There are a lot of things to make better here, but I'm just going to share a few things.

  First, you didn't have to use three different CSS files; you could have just adjusted styles using media query. Also about your script, its is no longer in vogue to use var declaration. Furthermore, instead of having a long chain of "if else" statements, you could have just used a switch block. By the way, most of the things you used js for could have been easily done with CSS.

  I hope you didn't find this review criticizing. Keep working and I can't wait to meet you at the top.

  Marked as helpful

  1
• 

  shahdevz•50

  @Shah-devsPosted over 1 year ago

  Hi Silas, well done. you did the mobile version great, I think your JS knowledge is far better than your CSS, because it changes to active state and also goes back in mobile version, however, I assume you did not mange to make the desktop version as good as mobile version ,unfortunately. Read up about media queries in css and also em and rem and percentages , you will be great.

  1