Submitted over 3 years ago
Article preview card using Sass and JS (for popups)
@syedalimansoor
Design comparison
SolutionDesign
Solution retrospective
Hello!
How did you get the image and the rest of the card to fit to a 2:3 ratio (or some similar ratio)? I ended up hard-coding a width for the image.
Feedback appreciated :)
Community feedback
- @RocTanweerPosted over 3 years ago
Another thing is that you should put aria-label to your button's attribute as there is no label or name for that.
On mobile, your pop-up wrapper's size is a bit larger that's why it is coming out of the container
1 - @RocTanweerPosted over 3 years ago
Hello π You put two elements in a parent element and set their width to 40% and 60% for 2:3 ratio
Remember percentage is relative to parent's width
Hope it helps(happy coding!)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord