Design comparison
Solution retrospective
Any feedback is welcome!!
Community feedback
- @DavidMorgadePosted over 2 years ago
Hello congrats on finishing the challenge!
Your site seems to be responsive and have the active states working properly, good work on that.
For your html tho I would use some better semantic tags, wrap your component in a
main
tag and divide it insections
instead ofdivs
.For the CSS try using a methodology such as BEM to organize your classnames, in this little component it doesn't make a different, but it can help you for future projects, you check up BEM here.
This little advice are for future big projects that requites a bit more of code and complexity, don't take them as a must-modify this little component, take them for future and bigger apps!
Hope my feedback helps you!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord