Design comparison
SolutionDesign
Solution retrospective
any suggestion pls
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @samson360-code!
Your solution looks great!
I have a couple of suggestions for improvement:
- For semantic reasons, use
main
for the main content instead ofsection
.
This change has no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
- Also, use
min-height: 100vh;
on the body instead ofheight: 100vh;
. Usingheight
may cause some bugs as well as part of the content being cut off on smaller screens.
I hope it helps!
Other than that, great job!
0 - For semantic reasons, use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord