Design comparison
Community feedback
- @mariokreitzPosted 3 days ago
What I noticed: The HTML structure is missing semantic tags. Try adding elements like <header>, <main>, <footer>, <article>, etc. These will make your code more readable and help with accessibility too! Plus, it’s a good habit to get into for SEO and screen readers. 👍
Right now, the structure is HTML-heavy, which can make things tricky to maintain. Since this challenge is focused on JavaScript, I’d suggest using JS templates or loading HTML directly via JavaScript. This will help modularize your code and make it more flexible if you need to update things later. It also brings in more JavaScript, which is the main goal here!
For the share menu, make sure it toggles open and close with the same button click—it’s a small thing but really smooths out the user experience.
Since this is a JS-focused challenge, go heavier on JavaScript by dynamically loading HTML templates. This will reduce hardcoded HTML and get you closer to that JS-centric approach.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord