article card component made with html, sass and js

Community feedback

• 

  Agata Liberska•3,995

  @AgataLiberskaPosted over 3 years ago

  Hi @Frankiiize! Well done on this challenge, I think it looks really good! Here are some things I noticed:

  • Because you're using a <div>, the share icon is not accessible for keyboard users, I think that should be a button

  • It would be good if you added some hover states to the share icon and the social media icons, as well as aria-labels for the links if you use an icon instead of text - so that screen reader users have some info on where the link will lead them :)

  • I would personally lower the max-width in mobile layout so that the card doesn't get so wide and you don't lose a lot of the image, but that's more of a design/personal preference thing I think :)

  Hope this helps :)

  0

  ---

  

  Francisco•145

  @FrankiiizePosted over 3 years ago

  Hi, thanks for the suggestions: D, I already made the changes and will update the solution, the truth was I was wondering how to solve the problem of the content of the links, it was very helpful. Greetings a hug!

  0

  

  Francisco•145

  @FrankiiizePosted over 3 years ago

  @AgataLiberska Do you know why it does not update the design comparison? I already made the changes, the other day I solved it by deleting the post and doing it again XD

  0