@vanzasetia
Posted
Hi, Sang Le!
Congratulations on completing this challenge! 🎉
Some suggestions from me.
- Based on the design comparison, the font family for the paragraph element is different from the design. So, I recommend fixing it.
- For the
gallery__heading, I recommend wrapping it with oneh1. You can usespanto break the text into two lines or limit the width withmax-width. - Each page should only contain one
h1.h1is used as a unique identifier for each page so that's why. So for thefooter__heading, change it toh2. - Wrap each social media icon with an anchor tag. Those are links to the social media accounts of the company.
- Never use
100vwon anything as it doesn't account for scrollbars when present. It may only ever introduce potential overflow/scroll bugs. - I highly recommend writing the styling using the mobile-first approach. It often leads to shorter and better performance code. Also, mobile users won't be required to process all of the desktop styles.
That's it! Hope this helps! Happy coding! 😄
Marked as helpful
@vanzasetia
Posted
@sqle157 Please remove the art-gallery-website-sketch.zip. It contains the design file which is against the license ("Re-selling or distributing free or premium challenge design files"). Next time, there's no need to upload the zip files and starter-files to the GitHub repository.
Also, it's best to keep the .gitignore file and upload it to the GitHub repository. It will prevent you from accidentally committing the design file as well. 🙂
@sqle157
Posted
@vanzasetia thank you for your feedbacks! It’s really helpful and informative
@vanzasetia
Posted
@sqle157 No problem! Don't forget to remove the zip files and the starter-files. 🙂
