Art gallery website

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Daniel! 👋

  Nice work on this challenge! 👍

  Your solution looks great on my desktop view and my portrait mobile view. But, on my landscape mobile view, the gallery section, specifically the image-grid-2.jpg doesn't have the same height as the gallery-container-dark.

  Some more feedback.

  • Remove the br from the hero-title. I recommend only specifying a flex-basis to prevent it from becoming one line.
  • I recommend making the arrow-right as a child element of the anchor tag. This way, you can remove the hero-btn-container element.
  • Alternative text should not be hyphenated (like code).
  • The arrow right icon and all the image-grid are decorative images. They don't give any additional information. So, I suggest leaving the alt="" empty to hide them all from screenreaders.
  • Remove the br from the footer-title as well.
  • The alternative for the social media icons should be only the social media platforms. The users of assistive technology will know that it is the social media site for the company. It's the same as sharing your social media links on your own website (there's no need to tell that those are the links to your social media accounts).
  • I recommend merging the location.css and the styles.css. It's best to share styling across multiple pages whenever possible. It's going to make the website much easier to maintain because you only care about one stylesheet (instead of two).
  • I don't think that the ourLocation-address should be a list.
  • For the location page, since there's only h1 and no h2, I recommend making the footer-title as h2 instead. Remember, headings must be in a logical order. Correctly formatted H1, H2s, and H3s help people who use assistive technology, such as screen readers, to navigate a web page.

  I hope this helps! Keep up the good work! 👍

  1