Design comparison
Solution retrospective
Hey there ! I would love some feedback, especially in my use of the picture element and whether this properly made use of images provided. Any other feedback would also be massively appreciated. I did use a small amout of JS as I'm learning this currently.
Thanks for taking the time to review my code ! Have a nice day !
Community feedback
- @0xabdulkhaliqPosted 9 months ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS 📐:
- The
max-width: 100vw
property forbody
is not necessary. because it's a block level element which will take the full width of the page by default.
- So feel free to remove
max-width: 100vw
style rule forbody
this will help you to write efficient code and helps you to remove redundant rules on your css file.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @Cristiano-Miguel-DCodeMasterPosted 9 months ago
Hi there! I really enjoyed your coding performance. Congratulations and I hope you keep growing.
Marked as helpful0@dboca93Posted 9 months ago@Cristiano-Miguel-DCodeMaster
Hello there, Thanks for you kind comment. It is much appreciated.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord