Skip to content
Submitted about 2 years ago

Applied media query for responsiveness

Paulo Lopez•60
@geekcrasher
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    Hello again Paulo, here's one tip about cleaning your code:

    Something I've noticed in your code is that in many occasions you've added some <div> to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be <div> or <main> if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    I hope this helps, happy coding!

    Marked as helpful
    0
  • kounik•300
    @Valhalla-2Posted about 2 years ago

    great job @geekcrasher on completing your first chanllange .Your design looks great. About your questions, semantic HTML means that the element itself have to describe it's meaning to the browser and to the developer, e.g <header> from this tag, we are getting a general idea that it will contain all the headers, <main> it will contain all of our main content of the webpage, <section> it will contain our sections, <form> etc , these are semantic html, non semantic are like <div>, <span> . For improvements you should put all of your content inside <main> tag, that way it would be more semantic, and also you could use relative units like % rather than using an absolute units like pixels, it will make your design more responsive . On smaller screen sizes your design breaks a little, so i will sugest on @media queries set the width size in percentages(%) , it would make your design more responsive .I am a newbie myself, so I hope i helped you a little, Happy coding journey 👍

    Marked as helpful
    0
    Paulo Lopez•60
    @geekcrasherPosted about 2 years ago

    @Valhalla-2 Hi! thank you for giving me a suggestion about relative units. And about the media query, I am honestly struggling with the techniques on how I'm going to make the content looks more responsive, especially on mobile devices.

    0
    kounik•300
    @Valhalla-2Posted about 2 years ago

    @geekcrasher responsiveness has bothered me alot , it still does ,,, This video of kevin powell helped me alot as a beginner , you could try that, I still watch it when i struggle with media queries.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord