applied CSS grid and media query for responsive design

Community feedback

• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi,

  Congrats on completing the challenge just some small things you can remove the height: 60% on the .container if you do that the columns will actually be centered on the page.

  On the body you can change the height: 100vh to min-height: 100vh to prevent content overflow.

  And on mobile you can just stack the columns.

  .cars {
      grid-template-columns: 1fr;
  }
  

  Hope these are helpful. Let me know if you have any other questions.

  Marked as helpful

  0

  ---

  

  Paulo Lopez•60

  @geekcrasherPosted about 2 years ago

  Hi, @hyrongennike! Thank you for your feedback.

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Paulo Lopez, congratulations for your new solution!

  1.Your solution seems fine, you did a really good work wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  2.About the semantics, you can replace all blocks that you've used <div> and replace with <article> thats a better html markup for this situation.

  3.Here's a complete guide for HTML semantic TAGS: https://www.w3schools.com/TAgs/default.asp

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Paulo Lopez•60

  @geekcrasherPosted about 2 years ago

  Hi, @correlucas! Thank you for giving me a suggestion about the class. And about the link that you've provided, I find it interesting to read.

  0