Design comparison
Solution retrospective
I had trouble getting the image to fit in the container correctly. The image had to be stretched to achieve this. The active state on the submit button was also challenging. In the end i made a new gradient that looked the same as the design.
Community feedback
- Account deleted
Hey there š! I'm impressed with how you successfully completed the challenge, congratulations! š
I have some recommendations for your JavaScript code that might be of interest to you.
I noticed that the way you declared your variables could use some improvement in terms of structure and organization. Consider taking a look at this example code which demonstrates a more efficient way of declaring variables:
const firstName = "Your"; const lastName = "Name"; const emailAddress = "[email protected]"; const password = "supersecret";
Instead of declaring each variable on a new line, you can declare multiple variables in a single line using commas to separate them. For example:
const firstName = "Your", lastName = "Name", emailAddress = "[email protected]" ā¢ā¢ā¢ ā¢ā¢ā¢ // n number of declarations password = "supersecret"; // don't forget to add a semicolon at the end of the last declaration
Using this method will help make your code more organized and easier to read.
I hope you find this suggestion helpful š. Your solution was great, and I'm excited to see more of your coding skills in the future!
Happy coding!
0@VCaramesPosted over 1 year ago@ktra99
Your comment "Consider taking a look at this example code which demonstrates a more efficient way of declaring variables" is incorrect, since both methods are valid ways of declaring variables. With neither method being better than the other.
I also noticed that you copied the comment from the feedback left by the earlier user. Please avoid doing this as it is unethical.
0@0xabdulkhaliqPosted over 1 year ago@ktra99 Please avoid Plagiarism,
Thanks
0 - @0xabdulkhaliqPosted over 1 year ago
Hello there š. Congratulations on successfully completing the challenge! š
- I have other recommendations regarding your code that I believe will be of great interest to you.
JAVASCRIPT š”:
- The way you declared variables are need to be well structured and organized
- Take a look at the following example code which describes an efficient way of declaring variables
const firstName = "Your"; const lastName = "Name"; const emailAddress = "[email protected]"; const password = "supersecret";
- instead try this,
const firstName = "Your", lastName = "Name", emailAddress = "[email protected]" ā¢ā¢ā¢ ā¢ā¢ā¢ // n number of declarations password = "supersecret"; // make sure to add a semicolon at end of last declaration
- This single line declaration with separated commas will helps you to have a better structured code and improves readability though
.
I hope you find this helpful š Above all, the solution you submitted is great !
Happy coding!
0@VCaramesPosted over 1 year ago@0xAbdulKhalid
Your comment "Take a look at the following example code which describes an efficient way of declaring variables" is incorrect, since both methods are valid ways of declaring variables. With neither method being better than the other.
0@0xabdulkhaliqPosted over 1 year ago@vcarames Roger that Sir !, Hereafter i'll correct it
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord