Apparel Coming Soon Page (Sass, Flexbox, JS)

Community feedback

• 

  Anna Leigh•5,135

  @brasspetalsPosted over 3 years ago

  Hi, Stas! 👋

  Congrats on completing another challenge! The mobile and desktop layout versions both look good. I see you’ve used flex, which is great! I encourage you to utilize it to create more responsive designs instead of two static layouts. It’s definitely tricky to come up with the “in-between” styles for these challenges, but worth the effort. 😄

  I also suggest changing your input type to “email” rather than “text”. The email input type also provides some extra form validation, which is nice.

  I see that you’ve used three h1 tags for the header - I originally did this in my solution too, but found out it’s not good HTML semantics as there should only ever be one h1 tag per page. Instead I suggest using just one h1 tag for the entire heading and keeping your span. One way you could control the line-breaking is by setting a max-width either to the h1 element or its container.

  Hope you’re enjoying beautiful, blue skies and golden sunshine all along the way. Have a great day (and happy coding)! 👋😎

  1

  ---

  

  Stas•30

  @aaltooPosted over 3 years ago

  @brasspetals Thank you! I'll be working on that

  0