API with dark mode using JQUERY Bootstrap

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Eslam, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add header tag and wrap the nav for improve the Accessibility
  • add descriptive text in the alt attribute of the images and not simple flag word
  • to make it look as close to the design as possible increase the size of h2 of countries cards
  • in the dark mode the text of search input is black and illegible
  • if i click country card the details page not open
  • instead of using px use relative units of measurement like rem -> read here
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • in the filters there is no way to return to all countries after choosing a region, add an entry "all region"
  • for the details of countries you can use ul instead multiple p

  Overall you did well 😁 Hope this help!

  Marked as helpful

  0

  ---

  

  Eslam Ismail•390

  @eslam-94Posted over 2 years ago

  @denielden thanks for your suggestions, i will fix them as soon as possible

  1