API REST COUNTRIES REACT

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Alexis, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • add header tag and wrap the navbar for improve the Accessibility
  • add main tag and wrap the page content for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of flag images
  • use one class to body to change the all theme color of app
  • after, add transition on the body to smooth the change theme color
  • instead of using px use relative units of measurement like rem -> read here
  • to make it look as close to the design as possible add border-radius: .5rem and overflow: hidden to country class
  • use ul element for the details text of country instead of multiple p
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • the details page have some problems

  Hope this help! Happy coding 😉

  1

  ---

  

  Alexis Champion•160

  @iTwiixZPosted about 2 years ago

  @denielden Merci pour le retour je prend note ! Pour le résultat où il n’y a pas d’erreur normal j’ai inclus cela mais ça ne semble pas fonctionner :(

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @iTwiixZ You are welcome! keep it up :)

  0

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @iTwiixZ try to verify with console.log what is the type of result when the search haven't result ;) If is a void obj it isen't undefined and the condition must be changend to work

  1