Api ReactJs SCSS

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 2 years ago

  Greetings. Here are some things that needs attention in your project

  • it is very important to use semantic html , that makes your site accessible . Elements such as divs should be the element of last resort , they have no semantic meaning. A site should have a heading element, usually the h1 heading is expected to be the first heading element of a site. Other elements to consider include the header, main and footer.
  • they are techniques that are considered best practice, with images you need to look at responsive image techniques such as srcset and picture element for displaying similar images between screen sizes. Using display: none to interchange between images is not a best practice - it wastes bandwidth, can slowdown the system when the site has a lot of images and expensive to use. Users will be forced to down images that they won't use which is the opposite of using the methods i initially mentioned.
  • the messages are not changing when i click the button

  Marked as helpful

  1

  ---

  

  Narender Singh•295

  @sinredneranPosted over 2 years ago

  @ChamuMutezva thanks for feedbacks. 1> I didn't consider using semantic tags because it wasn't under my priority. Although, it is a good practice. I focused more on using an API. 2>Regarding 2nd suggestion, that is very new for me to use scrset or other method rather than changing display. Thanks, for much detail about the alternatives, i will do some research about it. 3>As per it is written in the given API website, there should to be atleast 2 second gap before clicking the button else it won't change. If you are using firefox, there is a bug in firefox that won't refresh or redirect (something like that) to the API unless you reload the page or clear the cache.(even if we cleared the cache it would work for 1 time only, as i've seen on my computer) surprisingly it works fine on other browser and on my mobile device.

  0
• Account deleted

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I have some feedback on this solution:

  • put the quote inside a <blockquote> tag instead of p to be more semantic

  • check the HTML report to fix accessiblity issues

  i hope this is helpful and goodluck!

  1