
Design comparison
Solution retrospective
Edited version =)
What specific areas of your project would you like help with?Async JS and working with JSON data.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @dylan-dot-c
This is good tho the design could be better
For the async functions you did error handling alright but you could have also used an
alert
to notify the user that something went wrong. Other than that you could also use better variable names and for a challenge you could add a loading class to the dice that makes it spin while it fetches a new advice(not needed but fun to test your skills).You could also limit the use of margin as padding on the body would be better also if you used flex to center it you don't need any extra margin. This makes the mobile design looks abit weird so you can try to fix that.
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord