Any tips guys for what I need to improve?

Community feedback

• 

  Deepak Parmar•490

  @deepak-parmarPosted over 2 years ago

  @Troy, Add CSS cursor property to change the mouse cursor to pointer while hovering over Learn More buttons to show interactivity.

  Marked as helpful

  1

  ---

  

  Troy•170

  @troy03Posted over 2 years ago

  @deepak-parmar oh thats nice okay thank you so much!

  0
• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  To handle the responsive design across devices:

  body {
     //...
     min-height: 100vh;
     padding : 2rem;
  }
  
  main {
  /*     max-width: 920px; */   <--- Remove
  /*     min-height: 100vh; 500px; */   <--- Remove
  /*     margin: 10.6em auto 0 15.5em; */   <--- Remove
  /*     flex-direction: row; */   <--- Remove
  
      display: flex;
      align-items: center;
      justify-content: center;
  
      overflow: hidden;
      border-radius: 5px;
  } 
  
  section {
      max-width: 327px;
      padding: 2.5em;
  }
  
  
  /*  Remove this `media`
  @media (min-width: 480px) and (max-width: 768px) {
      body {
          display: flex;
          justify-content: center;
          align-items: center;
          flex-direction: column;
          margin-top: 6em;
          padding: 2em;
      }
      main{
          width: 660px;
          margin: auto;
          display: flex;
          flex-direction: column;
          margin: auto;
      }   
   } */
  
  /* Add This */
  @media (max-width: 992px) {
      main {
          flex-direction: column;
      }
  }
  

  Marked as helpful

  1

  ---

  

  Troy•170

  @troy03Posted over 2 years ago

  @Bayoumi-dev thank you so much going to study this media queries highly appreciated. I taking Odin Project anyway use this frontendmentor if I code this CSS with no tutorial needed haha

  0
• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey Troy, It looks good!...

  • Using more than one <h1> is allowed by the HTML specification, but is not considered a best practice. Using only one <h1> is beneficial for screenreader users.

  ---> Multiple <h1> elements on one page

  I hope this is useful to you... Keep coding👍

  2

  ---

  

  Troy•170

  @troy03Posted over 2 years ago

  @Bayoumi-dev ah okay its like h1 its like big text for a main page and my responsive design not working for mobile I tried to google thing but not working

  0